Uploaded image for project: 'Continuum'
  1. Continuum
  2. CONTINUUM-1721

SCM connection url should be optional when adding m2 projects

    Details

      Description

      Currently when you add a Maven 2 project to Continuum, it complains if you don't have a scm connection url in the pom.

      The scm elements are only really required for releasing, and not everyone uses the release feature of Maven/Continuum, so this should be optional.

      We could...

      • assume that the url you were given to fetch the pom from is also the scm url.
      • default to Subversion, and make the prefix (scm:svn configurable

      Related thread: http://www.nabble.com/Making-scm-connection-optional-td16570945.html

        Issue Links

          Activity

          Hide
          brettporter Brett Porter added a comment -

          it'd be good if we fixed this in a way that is consistent with CONTINUUM-1716 also, and the fact that updating from POMs could be optional via CONTINUUM-2188

          Show
          brettporter Brett Porter added a comment - it'd be good if we fixed this in a way that is consistent with CONTINUUM-1716 also, and the fact that updating from POMs could be optional via CONTINUUM-2188
          Hide
          wsmoak Wendy Smoak added a comment -

          There is a branch for this: https://svn.apache.org/repos/asf/continuum/branches/CONTINUUM-1721

          Originally, the scm username and password were inserted into the pom url very early-- in the action-- and the original pom url entered by the user was lost.

          I've removed that code, so currently on the branch you can't add a project that requires authentication to retrieve the pom. I think the code that inserts the credentials in the url belongs in a utility method somewhere closer to where the url-with-credentials actually gets used. In addition, I ran across code that pulls the username and password back out of the url.

          I started down the path of passing the url, username and password separately, but it's turning into quite a big change. (not committed)

          I need the original url preserved and available at the point where the Continuum scm url is set. Comments welcome.

          Show
          wsmoak Wendy Smoak added a comment - There is a branch for this: https://svn.apache.org/repos/asf/continuum/branches/CONTINUUM-1721 Originally, the scm username and password were inserted into the pom url very early-- in the action-- and the original pom url entered by the user was lost. I've removed that code, so currently on the branch you can't add a project that requires authentication to retrieve the pom. I think the code that inserts the credentials in the url belongs in a utility method somewhere closer to where the url-with-credentials actually gets used. In addition, I ran across code that pulls the username and password back out of the url. I started down the path of passing the url, username and password separately, but it's turning into quite a big change. (not committed) I need the original url preserved and available at the point where the Continuum scm url is set. Comments welcome.

            People

            • Assignee:
              Unassigned
              Reporter:
              wsmoak Wendy Smoak
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development