Uploaded image for project: 'Continuum'
  1. Continuum
  2. CONTINUUM-1590

updateBuildDefinitionForProjectGroup leads to a StackOverflowError

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Component/s: XMLRPC Interface
    • Labels:
      None

      Description

      This problem is due to a recursive call when testing the authorizations :

      At line 221 of ContinuumServiceImpl.java

      protected String getProjectGroupName( int projectGroupId )
      throws ContinuumException

      { ProjectGroupSummary pgs = getPGSummary( projectGroupId ); return pgs.getName(); }

      private ProjectGroupSummary getPGSummary( int projectGroupId )
      throws ContinuumException

      { checkViewProjectGroupAuthorization( getProjectGroupName( projectGroupId ) ); org.apache.maven.continuum.model.project.ProjectGroup projectGroup = continuum.getProjectGroup( projectGroupId ); return populateProjectGroupSummary( projectGroup ); }

      getProjectGroupName makes a call to getPGSummary that makes a call to getProjectGroupName that makes a call to getPGSummary ......

      I think the getPGSummary should be implemented like this :

      private ProjectGroupSummary getPGSummary( int projectGroupId )
      throws ContinuumException

      { org.apache.maven.continuum.model.project.ProjectGroup projectGroup = continuum.getProjectGroup( projectGroupId ); checkViewProjectGroupAuthorization( projectGroup.getName() ); return populateProjectGroupSummary( projectGroup ); }

      This problem also occurs in all these methods:

      • getProjectGroupSummary (line 242)
      • getProjectGroupWithProjects (line 253)
      • removeProjectGroup (line 264)
      • getProjects (line 91)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                olamy Olivier Lamy (*$^¨%`£)
                Reporter:
                ol ol
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: