Continuum
  1. Continuum
  2. CONTINUUM-1487

should not be allowed to delete a build result that is still executing

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1-beta-3
    • Fix Version/s: 1.1-beta-4
    • Component/s: None
    • Labels:
      None

      Description

      note that deleting the build result from on the build result page also seems to skip confirmation. All I did was hit the space bar...

        Activity

        Brett Porter created issue -
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        Sure we have to add a confirmation page for Delete Build Result(s)

        Show
        Olivier Lamy (*$^¨%`£) added a comment - Sure we have to add a confirmation page for Delete Build Result(s)
        Olivier Lamy (*$^¨%`£) made changes -
        Field Original Value New Value
        Fix Version/s 1.1-beta-4 [ 13727 ]
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        add confirmation page before delete buildResult(s) (svn rev 581740)

        Show
        Olivier Lamy (*$^¨%`£) added a comment - add confirmation page before delete buildResult(s) (svn rev 581740)
        Olivier Lamy (*$^¨%`£) made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Assignee Olivier Lamy [ olamy ]
        Hide
        Emmanuel Venisse added a comment -

        I'm not sure this issue is totally fixed. I think we need to not allow to delete a build result that is is running

        Show
        Emmanuel Venisse added a comment - I'm not sure this issue is totally fixed. I think we need to not allow to delete a build result that is is running
        Emmanuel Venisse made changes -
        Status Closed [ 6 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        Ok I see the point. We can check buildResult.state != ContinuumProjectState.BUILDING.
        This will work except when the build has been cancelled.
        In this case, I'm not sure we can know that and we must be able to delete this buildResult.
        Idea ?

        Show
        Olivier Lamy (*$^¨%`£) added a comment - Ok I see the point. We can check buildResult.state != ContinuumProjectState.BUILDING. This will work except when the build has been cancelled. In this case, I'm not sure we can know that and we must be able to delete this buildResult. Idea ?
        Hide
        Emmanuel Venisse added a comment -

        It isn't enough to check the state, because in some case it is always set to BUILDING, for example if you restart Continuum during a build.
        a build result is still executing if:

        • state = building
        • project/build definition of the build result is the current build
        Show
        Emmanuel Venisse added a comment - It isn't enough to check the state, because in some case it is always set to BUILDING, for example if you restart Continuum during a build. a build result is still executing if: state = building project/build definition of the build result is the current build
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        fixed in rev 582423. (prevent user deleting buildResult currently building)

        Show
        Olivier Lamy (*$^¨%`£) added a comment - fixed in rev 582423. (prevent user deleting buildResult currently building)
        Olivier Lamy (*$^¨%`£) made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        Warning message is not correct.

        Show
        Olivier Lamy (*$^¨%`£) added a comment - Warning message is not correct.
        Olivier Lamy (*$^¨%`£) made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        warning message (rev 582978)

        Show
        Olivier Lamy (*$^¨%`£) added a comment - warning message (rev 582978)
        Olivier Lamy (*$^¨%`£) made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 08:36:01 UTC 2015 [ 1428222961749 ]
        Mark Thomas made changes -
        Workflow jira [ 12710148 ] Default workflow, editable Closed status [ 12739795 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 21:12:18 UTC 2015 [ 1428268338676 ]
        Mark Thomas made changes -
        Workflow jira [ 12947336 ] Default workflow, editable Closed status [ 12985354 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        9d 7h 48m 1 Olivier Lamy (*$^¨%`£) 03/Oct/07 18:39
        Closed Closed Reopened Reopened
        2d 19h 41m 2 Olivier Lamy (*$^¨%`£) 08/Oct/07 05:42
        Reopened Reopened Closed Closed
        2d 3h 1m 2 Olivier Lamy (*$^¨%`£) 08/Oct/07 17:22

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            Brett Porter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development