[CONTINUUM-1168] Continuum mail notification should handle default SMTP port

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1-alpha-1
• Fix Version/s: 1.1-alpha-1
• Component/s: Notifier - Mail
• Environment: 1.1 SNAPSHOT 20070214 - Webapp version integrated with tomcat
• Assignee: Emmanuel Venisse
• Reporter: Stephane Nicoll
• Created: 15/Feb/07 02:12
• Updated: 15/Feb/07 03:45
• Resolved: 15/Feb/07 03:45

Description

I have integrated continuum 1.1 according to the doco on the wiki which defines a mail configuration like this

 <Resource name="mail/Session" auth="Container"
            type="javax.mail.Session"
            mail.smtp.host="localhost"/>

With this config, I got the following exception

9892685 [pool-1-thread-1] ERROR org.apache.maven.continuum.notification.ContinuumNotificationDispatcher:default  - Error while trying to use the mailnotifier.
org.codehaus.plexus.notification.NotificationException: Exception while sending message.
        at org.apache.maven.continuum.notification.mail.MailContinuumNotifier.sendMessage(MailContinuumNotifier.java:415)
        at org.apache.maven.continuum.notification.mail.MailContinuumNotifier.buildComplete(MailContinuumNotifier.java:319)
        at org.apache.maven.continuum.notification.mail.MailContinuumNotifier.sendNotification(MailContinuumNotifier.java:211)
        at org.apache.maven.continuum.notification.DefaultContinuumNotificationDispatcher.sendNotification(DefaultContinuumNotificationDispatcher.java:198)
        at org.apache.maven.continuum.notification.DefaultContinuumNotificationDispatcher.sendNotification(DefaultContinuumNotificationDispatcher.java:158)
        at org.apache.maven.continuum.notification.DefaultContinuumNotificationDispatcher.buildComplete(DefaultContinuumNotificationDispatcher.java:103)
        at org.apache.maven.continuum.buildcontroller.DefaultBuildController.endBuild(DefaultBuildController.java:219)
        at org.apache.maven.continuum.buildcontroller.DefaultBuildController.build(DefaultBuildController.java:173)
        at org.apache.maven.continuum.buildcontroller.BuildProjectTaskExecutor.executeTask(BuildProjectTaskExecutor.java:50)
        at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable$1.run(ThreadedTaskQueueExecutor.java:116)
        at edu.emory.mathcs.backport.java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
        at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.run(FutureTask.java:176)
        at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:987)
        at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:528)
        at java.lang.Thread.run(Thread.java:595)
Caused by: org.codehaus.plexus.mailsender.MailSenderException: Error while sending the message.
        at org.codehaus.plexus.mailsender.javamail.AbstractJavamailMailSender.send(AbstractJavamailMailSender.java:217)
        at org.apache.maven.continuum.notification.mail.MailContinuumNotifier.sendMessage(MailContinuumNotifier.java:411)
        ... 14 more
Caused by: java.lang.NumberFormatException: null
        at java.lang.Integer.parseInt(Integer.java:415)
        at java.lang.Integer.<init>(Integer.java:620)
        at org.codehaus.plexus.mailsender.javamail.AbstractJavamailMailSender.send(AbstractJavamailMailSender.java:197)
        ... 15 more

Continuum should handle the default SMTP port nicely. I know it's hardcoded in the plexus application version but it should be left off and 25 should be the default