[CONNECTORS-761] Jira connector, we can't save a connection

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: ManifoldCF 1.3
• Fix Version/s: ManifoldCF 1.3
• Component/s: JIRA connector
• Assignee: Karl Wright
• Reporter: Shinichiro Abe
• Created: 26/Jul/13 09:08
• Updated: 26/Jul/13 09:49
• Resolved: 26/Jul/13 09:49

Description

In Jira authority/repository connector, We can not create connections because there is startsWith method in JS file.

Then to fix this below:

Index: connectors/jira/connector/src/main/resources/org/apache/manifoldcf/authorities/authorities/jira/editConfiguration_jira_server.js
===================================================================
--- connectors/jira/connector/src/main/resources/org/apache/manifoldcf/authorities/authorities/jira/editConfiguration_jira_server.js	(revision 1507207)
+++ connectors/jira/connector/src/main/resources/org/apache/manifoldcf/authorities/authorities/jira/editConfiguration_jira_server.js	(working copy)
@@ -33,7 +33,7 @@
     return false;
   }
 
-  if (editconnection.jirapath.value != "" && !editconnection.jirapath.value.startsWith("/"))
+  if (editconnection.jirapath.value != "" && editconnection.jirapath.value.lastIndexOf("/", 0) != 0)
   {
     alert("$Encoder.bodyJavascriptEscape($ResourceBundle.getString('JiraAuthorityConnector.JiraPathMustBeginWithASlash'))");
     editconnection.jirapath.focus();
@@ -78,7 +78,7 @@
     return false;
   }
   
-  if (editconnection.jirapath.value != "" && !editconnection.jirapath.value.startsWith("/"))
+  if (editconnection.jirapath.value != "" && editconnection.jirapath.value.lastIndexOf("/", 0) != 0)
   {
     alert("$Encoder.bodyJavascriptEscape($ResourceBundle.getString('JiraAuthorityConnector.JiraPathMustBeginWithASlash'))");
     SelectTab("$Encoder.bodyJavascriptEscape($ResourceBundle.getString('JiraAuthorityConnector.Server'))");
Index: connectors/jira/connector/src/main/resources/org/apache/manifoldcf/crawler/connectors/jira/editConfiguration_jira_server.js
===================================================================
--- connectors/jira/connector/src/main/resources/org/apache/manifoldcf/crawler/connectors/jira/editConfiguration_jira_server.js	(revision 1507207)
+++ connectors/jira/connector/src/main/resources/org/apache/manifoldcf/crawler/connectors/jira/editConfiguration_jira_server.js	(working copy)
@@ -33,7 +33,7 @@
     return false;
   }
 
-  if (editconnection.jirapath.value != "" && !editconnection.jirapath.value.startsWith("/"))
+  if (editconnection.jirapath.value != "" && editconnection.jirapath.value.lastIndexOf("/", 0) != 0)
   {
     alert("$Encoder.bodyJavascriptEscape($ResourceBundle.getString('JiraRepositoryConnector.JiraPathMustBeginWithASlash'))");
     editconnection.jirapath.focus();
@@ -78,7 +78,7 @@
     return false;
   }
   
-  if (editconnection.jirapath.value != "" && !editconnection.jirapath.value.startsWith("/"))
+  if (editconnection.jirapath.value != "" && editconnection.jirapath.value.lastIndexOf("/", 0) != 0)
   {
     alert("$Encoder.bodyJavascriptEscape($ResourceBundle.getString('JiraRepositoryConnector.JiraPathMustBeginWithASlash'))");
     SelectTab("$Encoder.bodyJavascriptEscape($ResourceBundle.getString('JiraRepositoryConnector.Server'))");

Also, even after fixing above, In Jira authority connection, the behavior of server tab is clumsy.
Please check this.