ManifoldCF
  1. ManifoldCF
  2. CONNECTORS-356

Active Directory connector should by fully I18N/L10N

    Details

      Description

      All messages in Active Directory Connector should be extracted out to properties file.
      Also, should create Japanese L10N properties file for all messages.

        Activity

        Hitoshi Ozawa created issue -
        Hide
        Hitoshi Ozawa added a comment -

        Extract out all messages to properties file and add Japanese messages.

        Show
        Hitoshi Ozawa added a comment - Extract out all messages to properties file and add Japanese messages.
        Hitoshi Ozawa made changes -
        Field Original Value New Value
        Attachment CONNECTORS-356.patch [ 12509898 ]
        Karl Wright made changes -
        Assignee Karl Wright [ kwright@metacarta.com ]
        Hide
        Karl Wright added a comment -

        For what it is worth, patches should always be rooted at trunk. I'll commit this, but please bear this in mind for the future.

        Show
        Karl Wright added a comment - For what it is worth, patches should always be rooted at trunk. I'll commit this, but please bear this in mind for the future.
        Hide
        Karl Wright added a comment - - edited

        I've looked at this patch. It embeds the Javascript etc. quotation marks right in the translation. I believe this to be bad practice since the localization is then based on the context in which it is used.

        For example:

        +"    alert(" + Messages.getString(locale,"ActiveDirectoryAuthority.EnterADomainControllerServerName") + ");\n"+
        

        ...combined with...

        +ActiveDirectoryAuthority.EnterADomainControllerServerName=\"Enter a domain controller server name\"
        

        I think this should be:

        +"    alert(\"" + Messages.getBodyJavascriptString(locale,"ActiveDirectoryAuthority.EnterADomainControllerServerName") + "\");\n"+
        

        ... and ...

        +ActiveDirectoryAuthority.EnterADomainControllerServerName=Enter a domain controller server name
        

        Do you agree?

        Show
        Karl Wright added a comment - - edited I've looked at this patch. It embeds the Javascript etc. quotation marks right in the translation. I believe this to be bad practice since the localization is then based on the context in which it is used. For example: + " alert(" + Messages.getString(locale, "ActiveDirectoryAuthority.EnterADomainControllerServerName" ) + ");\n" + ...combined with... +ActiveDirectoryAuthority.EnterADomainControllerServerName=\ "Enter a domain controller server name\" I think this should be: + " alert(\" " + Messages.getBodyJavascriptString(locale," ActiveDirectoryAuthority.EnterADomainControllerServerName ") + " \ ");\n" + ... and ... +ActiveDirectoryAuthority.EnterADomainControllerServerName=Enter a domain controller server name Do you agree?
        Hide
        Karl Wright added a comment -

        r1229212

        Show
        Karl Wright added a comment - r1229212
        Hide
        Karl Wright added a comment -

        r1229277

        Show
        Karl Wright added a comment - r1229277
        Karl Wright made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hitoshi Ozawa added a comment -

        For what it is worth, patches should always be rooted at trunk. I'll commit this, but please bear this in mind for the future.

        I thought you wanted a separate issue for each connector.

        Show
        Hitoshi Ozawa added a comment - For what it is worth, patches should always be rooted at trunk. I'll commit this, but please bear this in mind for the future. I thought you wanted a separate issue for each connector.
        Hide
        Karl Wright added a comment -

        I thought you wanted a separate issue for each connector.

        Separate issue, separate patch, but patch should be created so that it can be applied from the trunk directory, not somewhere deep in the hierarchy. You can create such a diff like this:

        cd ~/mcf/trunk
        svn diff connectors/xyz >CONNECTORS-123.patch
        
        Show
        Karl Wright added a comment - I thought you wanted a separate issue for each connector. Separate issue, separate patch, but patch should be created so that it can be applied from the trunk directory, not somewhere deep in the hierarchy. You can create such a diff like this: cd ~/mcf/trunk svn diff connectors/xyz >CONNECTORS-123.patch
        Hide
        Hitoshi Ozawa added a comment -

        Got you. Will do from next time.

        Show
        Hitoshi Ozawa added a comment - Got you. Will do from next time.
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        4h 43m 1 Karl Wright 09/Jan/12 17:56

          People

          • Assignee:
            Karl Wright
            Reporter:
            Hitoshi Ozawa
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development