[CONNECTORS-1434] Bad characters in file name can cause Solr 500 errors

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: ManifoldCF 2.7
• Fix Version/s: ManifoldCF 2.8
• Component/s: Lucene/SOLR connector
• Assignee: Karl Wright
• Reporter: Karl Wright
• Created: 21/Jun/17 09:55
• Updated: 22/Jun/17 09:56
• Resolved: 22/Jun/17 09:56

Description

There are reports that quotes or spaces in a file name can blow up the Solr indexing of the document and cause it to throw a 500 error.

The code in question (from ModifiedHttpSolrClient) is the following:

            String name = content.getName();
            if (name == null) {
              name = "";
            }
            parts.add(new FormBodyPart(name,
                new InputStreamBody(
                    content.getStream(),
                    contentType,
                    content.getName())));

... where content.getName() would be returning a name with illegal characters. The question is, what does httpclient do with this name, and should it be escaping it in some way?