[CONNECTORS-1413] Code smell in equals implementation

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: ManifoldCF 2.8
• Component/s: CMIS connector
• Assignee: Furkan Kamaci
• Reporter: JC
• Created: 18/Apr/17 18:20
• Updated: 18/Apr/17 19:11
• Resolved: 18/Apr/17 19:11

Description

Hi

In a recent snapshot, I've found a suspicious code in connectors/cmis/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/cmis/CmisAuthorityConnector.java

402       public boolean equals(Object o)
403       {
404         if (!(o instanceof AuthorizationResponseDescription))
405           return false;
406         AuthorizationResponseDescription ard = (AuthorizationResponseDescription)o;
407         return ard.userName.equals(userName) && ard.endpoint.equals(endpoint) &&
408           repositoryId.equals(repositoryId);
409       }

In Line 408, repositoryId.equals(repositoryId) should be repositoryId.equals(ard.repositoryId)? This might be a trivial issue but wanted to report just in case. Thanks!