[CONFIGURATION-302] FileChangedReloadingStrategy.reloadingRequired() can fail

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5
• Fix Version/s: 1.6
• Assignee: Oliver Heger
• Reporter: Pino Navato
• Created: 14/Dec/07 12:37
• Updated: 22/Aug/09 19:36
• Resolved: 25/Dec/07 19:06

Description

If reloadingRequired() returns true and you call it again before calling reloadingPerformed(), the 2nd time it can return false (but you have not yet reloaded!) because it doesn't check the file system again until the refresh delay is expired.
Of course this is a very unusual test case (usually you reload immediately) but the behaviour of the method should be consistent in this case too: if reloadingRequired() returns true any subsequent call to this method should return true until reloadingPerformed() is called.

In my project I have fixed the method by promoting the flag called "reloading" to class scope so I that can check whether the previous call returned true or false:

protected boolean reloading = false;
public boolean reloadingRequired()
{
if (!reloading)
{
long now = System.currentTimeMillis();
if (now > lastChecked + refreshDelay)
{
lastChecked = now;
if (hasChanged())

{ reloading = true; }

}
}
return reloading;
}

Of course I reset this flag in init() and reloadingPerformed().