Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Nightly Builds
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: other
      Platform: Other

      Description

      This is a patch to add a custom header to .properties files and match the
      features of the ExtendedProperties class in [collections] so that it can be
      deprecated. I preferred using a get/setHeader instead of a header parameter on
      the save method, this will spare the hassle of carrying the header every time
      the configuration has to be saved.

        Issue Links

          Activity

          Hide
          Emmanuel Bourg added a comment -

          Marking as fixed since the header is implemented. I'm opening COM-2256 to deal
          with the parsing issue.

          Show
          Emmanuel Bourg added a comment - Marking as fixed since the header is implemented. I'm opening COM-2256 to deal with the parsing issue.
          Hide
          Emmanuel Bourg added a comment -

          I applied the patch, the header is not parsed yet when the file is loaded.

          Show
          Emmanuel Bourg added a comment - I applied the patch, the header is not parsed yet when the file is loaded.
          Hide
          Emmanuel Bourg added a comment -

          Reopening, AFAIK the header worked for ExtendedProperties, if it didn't it's
          still a valid enhancement request.

          Show
          Emmanuel Bourg added a comment - Reopening, AFAIK the header worked for ExtendedProperties, if it didn't it's still a valid enhancement request.
          Hide
          David Eric Pugh added a comment -

          I am marking this as wontfix.. I mean, if the .properties header never worked
          in ExtendedProperties, then lets not keep it in Configuration as well....

          Show
          David Eric Pugh added a comment - I am marking this as wontfix.. I mean, if the .properties header never worked in ExtendedProperties, then lets not keep it in Configuration as well....
          Hide
          Emmanuel Bourg added a comment -

          The include is a different beast actually, it's another configuration linked to
          the one being loaded. The header is just a comment at the beginning of the file.

          I didn't think at reading the header as well but that might be a nice addition.
          The patch just aims at matching the features of the ExtendedProperties class,
          and it was neither able to load the header.

          Show
          Emmanuel Bourg added a comment - The include is a different beast actually, it's another configuration linked to the one being loaded. The header is just a comment at the beginning of the file. I didn't think at reading the header as well but that might be a nice addition. The patch just aims at matching the features of the ExtendedProperties class, and it was neither able to load the header.
          Hide
          David Eric Pugh added a comment -

          I have a question about this patch. I looked at it, and I don't quite see the
          difference between the set/getHeader and the set/getInclude method? Also, on
          the save, I see how you include the header.properties stuff into the writing,
          but I don't see how it loads? Are you sure we need this instead of using the
          include stuff?

          Show
          David Eric Pugh added a comment - I have a question about this patch. I looked at it, and I don't quite see the difference between the set/getHeader and the set/getInclude method? Also, on the save, I see how you include the header.properties stuff into the writing, but I don't see how it loads? Are you sure we need this instead of using the include stuff?
          Hide
          Emmanuel Bourg added a comment -

          Created an attachment (id=9932)
          Patch adding header support

          Show
          Emmanuel Bourg added a comment - Created an attachment (id=9932) Patch adding header support

            People

            • Assignee:
              Unassigned
              Reporter:
              Emmanuel Bourg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development