Commons Compress
  1. Commons Compress
  2. COMPRESS-69

Inconsistent handling of BZ2-Header after redesign

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None

      Description

      I tried the current trunk of compress and tried the BZIP2-Streams. There are the following inconsitenceis now:
      a) BZIP InputStream checks that the "BZ" header is available in the File (using this magicChar method)
      b) BZIP OutputStream does not add the "BZ" header (it is commented out, saying that the caller does this)
      c) The Javadocs of the input stream say, you should skip the header, which is wrong.
      d) the tests do not find these errors, as the test only compressed a file, but does not try to decompress it or check its contents

      Before the redesign commit, the handling of headers was consistent (both streams used it). The BZ Headers should be added to the Streams, as this would be consistent with GZIP (where the headers are automatically added, too).

      1. COMPRESS-69.patch
        1 kB
        Uwe Schindler

        Activity

        Uwe Schindler created issue -
        Christian Grobmeier made changes -
        Field Original Value New Value
        Fix Version/s 1.0 [ 12313768 ]
        Affects Version/s 1.0 [ 12313768 ]
        Uwe Schindler made changes -
        Attachment COMPRESS-69.patch [ 12405324 ]
        Christian Grobmeier made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Christian Grobmeier made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development