Commons Compress
  1. Commons Compress
  2. COMPRESS-52

ZipEntry supports JDK 1.1 - refactor code to be 1.2+

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The ZipEntry class goes to a lot of work to support JDK 1.1 and a fair chunk of code can be deleted by removing the 1.1 workarounds.

        Issue Links

          Activity

          Hide
          Christian Grobmeier added a comment -

          Of course BZIP was updated.
          The patch of 248 should work for 244.

          Show
          Christian Grobmeier added a comment - Of course BZIP was updated. The patch of 248 should work for 244.
          Hide
          Christian Grobmeier added a comment -

          ZipEntry (meanwhile named ZipArchiveEntry) comes from the Ant project. If we start to work on that code, we will have a differnece to Ant and that makes it difficult to update new impls from them.

          We have updated the compress code with ant code yesterday and stuff should be more cool now. I guess this issue is obsolete. You may want to have a new look on it.

          If not, I would close this as "won't fix" until some Ant-Comitters decide that they would like to improve their Ant-Classes in the Compress-Trunk There is no need to have two seperatly developed codebases, imho.

          Show
          Christian Grobmeier added a comment - ZipEntry (meanwhile named ZipArchiveEntry) comes from the Ant project. If we start to work on that code, we will have a differnece to Ant and that makes it difficult to update new impls from them. We have updated the compress code with ant code yesterday and stuff should be more cool now. I guess this issue is obsolete. You may want to have a new look on it. If not, I would close this as "won't fix" until some Ant-Comitters decide that they would like to improve their Ant-Classes in the Compress-Trunk There is no need to have two seperatly developed codebases, imho.
          Hide
          Torsten Curdt added a comment -

          @Sebb: target is 1.4+ so that's fine but we should really get rid of the cruft in ZipEntry then

          Show
          Torsten Curdt added a comment - @Sebb: target is 1.4+ so that's fine but we should really get rid of the cruft in ZipEntry then
          Hide
          Sebb added a comment -

          BTW, PackableObject uses String.split() which is Java 1.4+

          Also, ArchiveException and some other exceptions call initCause() which is 1.4+ as well.

          Show
          Sebb added a comment - BTW, PackableObject uses String.split() which is Java 1.4+ Also, ArchiveException and some other exceptions call initCause() which is 1.4+ as well.

            People

            • Assignee:
              Torsten Curdt
              Reporter:
              Henri Yandell
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development