[COMPRESS-459] CPIO fails decoding multibyte name entries

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9, 1.17
• Fix Version/s: 1.18
• Component/s: Archivers
• Labels: patch-available
• Assignee: Unassigned
• Reporter: Jens Reimann
• Created: 09/Jul/18 08:06
• Updated: 13/Jul/18 06:24
• Resolved: 11/Jul/18 16:53

Description

Having a CPIO archive in (e.g. UTF-8) mode and having a name entry with a name containing multi-byte characters the decoder fails.

The problem IMHO is the "getHeaderPadCount" method, which assumes a single byte per character:

 

    public int getHeaderPadCount(){
        if (this.alignmentBoundary == 0) { return 0; }
        int size = this.headerSize + 1;  // Name has terminating null
        if (name != null) {
            size += name.length();
        }
        final int remain = size % this.alignmentBoundary;
        if (remain > 0){
            return this.alignmentBoundary - remain;
        }
        return 0;
    }

However this may (or may not) be true for UTF-8.

 

Also it wouldn't be enough to call "String#getBytes(…)" as this might already transform the underlying bytes.

The proper solution would be to provide the name size, as read from the CPIO stream, and pass it to the entry.

Issue Links

• links to: GitHub Pull Request #67