[COMPRESS-421] TarUtils.parseName does not follow the spec - ASF JIRA

XML

Word

Printable

JSON

TarUtils.parseName does not stop at the first NUL byte, resulting in non-empty strings where they should be empty.

This manifests if the tar file contains a star_header struct instead of a posix_header as defined in https://www.gnu.org/software/tar/manual/html_node/Standard.html

The javadoc on parseName states "Parse an entry name from a buffer. Parsing stops when a NUL is found or the buffer length is reached."

However, the implementation starts at the end of the buffer and stops when the first non-NUL is found.

The solution is to replace:

  int len = length;
  for (; len > 0; len--) {
    if (buffer[offset + len - 1] != 0) {
      break;
    }
  }

  int len = 0;
  for (int i = offset; len < length && buffer[i] != 0; i++, len++);

links to

GitHub Pull Request #53