[COMPRESS-302] Retore immutability/thread-safety to ArchiveStreamFactory

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9
• Fix Version/s: 1.10
• Assignee: Unassigned
• Reporter: Sebb
• Created: 15/Feb/15 17:34
• Updated: 15/Feb/15 23:11
• Resolved: 15/Feb/15 23:11

Description

COMPRESS-180 added support for encoding.
Unfortunately this was done in a way that broke immutability.
Also the factory is no longer thread-safe as the encoding field is not synch/volatile.

Consider whether to restore immutability, e.g. by adding a constuctor which takes the encoding setting. The setEntryEncoding method could be deprecated intitially and eventually dropped.

One way to support immutability now would be to add a second final encoding field which is set by a new ctor. See patch to follow.