[COMPRESS-268] Buffer not read first time for entries with STORED compression method

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.7
• Fix Version/s: 1.8
• Component/s: Archivers
• Labels: archive zip

Environment

• Fedora 20 x64
• Java 1.7.0_51 x64
• archive created with Nautilus' context menu

• Assignee: Unassigned
• Reporter: Radu Almășan
• Created: 28/Feb/14 22:28
• Updated: 01/Mar/14 05:59
• Resolved: 01/Mar/14 05:59

Description

Trying to extract a ZIP archive that contains entries with STORED compression method, the ZipArchiveInputStream.readStored(byte[], int, int) method is called. At this point, because the buf array has not had a chance to be populated with values from the underlying input stream and because there's no condition to detect this, the resulting content is prefixed with the buffer's length (512) of 0 bytes.

I've found that chancing:

if (buf.position() >= buf.limit()) {

with

if (buf.position() >= buf.limit() || current.bytesReadFromStream == 0) {

solves the issue.

Issue Links

• duplicates: COMPRESS-264 ZIP reads correctly with commons-compress 1.6, gives NUL bytes in 1.7