[COMPRESS-23] [compress] TarInputStream returns negative value for read() [PATCH]

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed

Environment

Operating System: All
Platform: All

• Bugzilla Id: 36243
• Assignee: Torsten Curdt
• Reporter: Adrian Pronk
• Created: 18/Aug/05 22:15
• Updated: 18/Apr/10 09:22
• Resolved: 07/Jan/09 13:59

Description

TarInputStream.read() does not convert the byte it has read to a positive number
after casting it to an integer. This causes downstream processes to fail to
recognise the value properly.

Index: org/apache/commons/compress/tar/TarInputStream.java
===================================================================
— org/apache/commons/compress/tar/TarInputStream.java (revision 231420)
+++ org/apache/commons/compress/tar/TarInputStream.java (working copy)
@@ -306,7 +306,7 @@
}
else

{ - return (int)m_oneBuf[ 0 ]; + return (int)m_oneBuf[ 0 ] & 0xFF; }

}

Issue Links

• is duplicated by: COMPRESS-33 [compress] TarInputStream.read() returns wrong values