Commons Compress
  1. Commons Compress
  2. COMPRESS-200

Round trip conversion with more than 66 US-ASCII characters fails when using TarArchiveOutputStream.LONGFILE_GNU

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.1
    • Fix Version/s: 1.5
    • Component/s: Archivers
    • Labels:
      None
    • Environment:

      Any

      Description

      When using TarArchiveOutputStream.LONGFILE_GNU with an entry name of more than 66 US-ASCII characters, a round trip conversion (write the entry, then read it back) fails because of several bugs in TarArchiveOutputStream and TarArchiveInputStream.

      This has been reported as an issue to TrueZIP, which is why you can find a more detailed analysis here: http://java.net/jira/browse/TRUEZIP-286 .

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        129d 4h 1 Stefan Bodewig 27/Dec/12 21:07
        Hide
        Christian Schlichtherle added a comment -

        Nevermind, I'll build it myself.

        Show
        Christian Schlichtherle added a comment - Nevermind, I'll build it myself.
        Hide
        Christian Schlichtherle added a comment -

        Thanks a lot! Where is the snapshot repository I can point Maven to?

        Show
        Christian Schlichtherle added a comment - Thanks a lot! Where is the snapshot repository I can point Maven to?
        Stefan Bodewig made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Stefan Bodewig added a comment -

        fixed with svn revision 1426319

        Show
        Stefan Bodewig added a comment - fixed with svn revision 1426319
        Hide
        Stefan Bodewig added a comment -

        OK, I now have a test case, I need to specify an encoding explicitly since the bug doesn't raise its head when using FallBackZipEncoding.

        Show
        Stefan Bodewig added a comment - OK, I now have a test case, I need to specify an encoding explicitly since the bug doesn't raise its head when using FallBackZipEncoding.
        Hide
        Stefan Bodewig added a comment -

        First of all sorry for the long hiatus, I won't promise any changes, but let's see.

        I've committed a unit test with svn revision 1426276 - http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStreamTest.java?r1=1426276&r2=1426275&pathrev=1426276 and it passes.

        I'll look into Christian's analysis more closely soonish - if we really are using the ByteBuffer the wrong way (quite possible), then this may also affect the zip package. Anyway, it would be good if we had a unit test that actually failed before I start "fixing" it.

        Unfortunately java.net is in a bad mood right now and I can't get to the thread refered to in the JIRA ticket over there - and I can't create an account in TrueZIP's JIRA right now either.

        Show
        Stefan Bodewig added a comment - First of all sorry for the long hiatus, I won't promise any changes, but let's see. I've committed a unit test with svn revision 1426276 - http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStreamTest.java?r1=1426276&r2=1426275&pathrev=1426276 and it passes. I'll look into Christian's analysis more closely soonish - if we really are using the ByteBuffer the wrong way (quite possible), then this may also affect the zip package. Anyway, it would be good if we had a unit test that actually failed before I start "fixing" it. Unfortunately java.net is in a bad mood right now and I can't get to the thread refered to in the JIRA ticket over there - and I can't create an account in TrueZIP's JIRA right now either.
        Hide
        Janos Gyerik added a comment -

        This issue is hitting us TrueZip users too. Speaking of which big thanks to Christian for TrueZip.

        Show
        Janos Gyerik added a comment - This issue is hitting us TrueZip users too. Speaking of which big thanks to Christian for TrueZip.
        Hide
        Christian Schlichtherle added a comment -

        Thanks, but I'm busy taking care of my own mess.

        Show
        Christian Schlichtherle added a comment - Thanks, but I'm busy taking care of my own mess.
        Hide
        Gary Gregory added a comment -

        As a volunteer here, I can say that if you are not happy with the current state of an issue, the best way to move it forward is to put some elbow grease into it and provide a patch

        Show
        Gary Gregory added a comment - As a volunteer here, I can say that if you are not happy with the current state of an issue, the best way to move it forward is to put some elbow grease into it and provide a patch
        Hide
        Christian Schlichtherle added a comment -

        Two months later still nobody cares?

        Show
        Christian Schlichtherle added a comment - Two months later still nobody cares?
        Hide
        Christian Schlichtherle added a comment -

        The same problem applies when using LONGFILE_POSIX.

        Show
        Christian Schlichtherle added a comment - The same problem applies when using LONGFILE_POSIX.
        Christian Schlichtherle created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Christian Schlichtherle
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development