Commons Compress
  1. Commons Compress
  2. COMPRESS-15

COMPRESS-REDESIGN: ArchiveStreamFactory does not handle exceptions for createArchiveInputStream(InputStream)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      N/A

      Description

      Reflection handles the checked exceptions for Constructor.newInstance() appropriately for:

      public ArchiveInputStream createArchiveInputStream( final String archiverName, final InputStream out ) throws ArchiveException

      {...}

      However, the other method:

      public ArchiveInputStream createArchiveInputStream( final InputStream input ) throws IOException {...}

      is not implemented to handle checked constructor exceptions since all Exception catches are not handled. It looks as though this method was not completed. This method should handle exceptions similar to its counterpart.

      1. patch-improve-factories.txt
        13 kB
        Christian Grobmeier
      2. ArchiveStreamFactory.patch
        6 kB
        Tim Pinet

        Activity

        Dennis Lundberg made changes -
        Project Commons Sandbox [ 12310491 ] Commons Compress [ 12310904 ]
        Key SANDBOX-262 COMPRESS-15
        Component/s Compress [ 12311183 ]
        Torsten Curdt made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Torsten Curdt made changes -
        Assignee Torsten Curdt [ tcurdt ]
        Christian Grobmeier made changes -
        Attachment patch-improve-factories.txt [ 12397271 ]
        Tim Pinet made changes -
        Field Original Value New Value
        Attachment ArchiveStreamFactory.patch [ 12391506 ]
        Tim Pinet created issue -

          People

          • Assignee:
            Torsten Curdt
            Reporter:
            Tim Pinet
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 5h
              5h
              Remaining:
              Remaining Estimate - 5h
              5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development