[COLLECTIONS-825] BloomFilter: drop SimpleHasher.getDefaultIncrement

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Done
• Fix Version/s: 4.5
• Labels: bloom-filter
• Assignee: Claude Warren
• Reporter: Claude Warren
• Created: 15/Jun/22 08:50
• Updated: 09/Aug/22 08:30
• Resolved: 09/Aug/22 08:30

Description

src/main/java/org/apache/commons/collections4/bloomfilter/SimpleHasher.java
     * </p>
     * @return The default increment to use when the requested increment is zero.
     */
    public long getDefaultIncrement() {
Member

@aherbert aherbert on 27 Feb

I think this should be dropped. The default increment will fix the rare case 1 in 2^64 that the increment is zero. But it does not fix the more common case (1 in nbits) that the increment for the shape will be zero. Dropping this simplifies the constructor. A zero increment can be handled later.
@Claude-at-Instaclustr Claude-at-Instaclustr on 10 Mar

This is to handle the case where an existing implementation has chosen a different default value while still allowing the commons code to drop in place.

Issue Links

• is a child of: COLLECTIONS-728 BloomFilter contribution