Uploaded image for project: 'Commons Collections'
  1. Commons Collections
  2. COLLECTIONS-773

The method AbstractHashedMap#ensureCapacity is not tested

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Nightly Builds, 4.3, 4.4
    • Fix Version/s: 4.5
    • Component/s: Map
    • Labels:

      Description

      Hi Apache 🏹!

      I notice that method AbstractHashedMap#ensureCapacity seems quite important, it is executed 11885 times by the test suite.

      Yet, when I completely remove the body of the method, leaving the method doing nothing, no test breaks.

      It that normal or should we add test or an assertion to specify its behavior?

      Thanks a lot for the great library!

      --Martin

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              monperrus Martin Monperrus

              Dates

              • Created:
                Updated:
                Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 40m
              40m

                Issue deployment