[COLLECTIONS-738] The last assertNull in IterableUtilsTest.find is redundant

• Type: Test
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.4
• Fix Version/s: 4.5.0-M1
• Component/s: Iterator
• Assignee: Bruno P. Kinoshita
• Reporter: Pengyu Nie
• Created: 29/Nov/19 17:13
• Updated: 09/Jan/20 07:22
• Resolved: 09/Jan/20 07:22

Description

The last assertNull in IterableUtilsTest.find (line 277, as shown
below), is redundant and confusing; it will not be invoked because
IterableUtils.find(*, null) should not return any value but just throw
NullPointerException. I will make a PR to clarify this.

try {
    assertNull(IterableUtils.find(iterableA, null));
    fail("expecting NullPointerException");
} catch (final NullPointerException npe) {
    // expected
}

Issue Links

• links to: GitHub Pull Request #121