[COLLECTIONS-737] The test FluentIterableTest.size should be split

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.4
• Fix Version/s: 4.5.0-M1
• Component/s: Collection
• Assignee: Bruno P. Kinoshita
• Reporter: Pengyu Nie
• Created: 26/Nov/19 21:39
• Updated: 28/Mar/20 21:22
• Resolved: 28/Mar/20 05:15

Description

The first part of FluentIterableTest.size is not testing function
FluentIterable.size (see code copied below). Actually,
FluentIterable.size will not be invoked at all, because
FluentIterable.of(null) will throw an NPE before that. This part
should be extracted as a separate unit test like
FluentIterableTest.ofNull.

try {
    FluentIterable.of((Iterable<?>) null).size();
    fail("expecting NullPointerException");
} catch (final NullPointerException npe) {
    // expected
}

I'll create a pull request for this issue.

Issue Links

• links to: GitHub Pull Request #120