Uploaded image for project: 'Commons Collections'
  1. Commons Collections
  2. COLLECTIONS-736

CollectionUtils containsAny Improvement

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 4.4
    • Fix Version/s: None
    • Component/s: Collection
    • Labels:
      None

      Description

      I think it's better to judge null in the code rather than let the user pass non null parameters.

       

      For example, add such a piece of code:

      if (isEmpty(coll1) || isEmpty(coll2)) {
          return false; 
      }
      

      It might be better in this way.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              2472678187 木易什么来着
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: