[COLLECTIONS-712] ExtendedProperties.save swallows instead of throws IOException

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Won't Fix
• Affects Version/s: 3.2.2
• Component/s: Properties
• Assignee: Unassigned
• Reporter: Philip Hodges
• Created: 18/Mar/19 13:39
• Updated: 05/Jul/19 17:23
• Resolved: 05/Jul/19 15:31

Description

commons-collections-3.2.2-src/src/java/org/apache/commons/collections/ExtendedProperties.java

/**
 * Save the properties to the given output stream.
 * ...
 * @throws IOException if an IO error occurs - no it does not.
 */
public synchronized void save(OutputStream output, String header) throws IOException {
...
PrintWriter theWrtr = new PrintWriter(output);
...
// theWrter.flush();
// missing: if (theWrtr.checkError()) throw new IOException();

Impact: caller cannot tell if the properties were completely saved, perhaps the disk filled up instead. Missing checkError is an antipattern for PrintWriter and PrintStream.