[COLLECTIONS-472] wasted work in AbstractMapBag.containsAll()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.1
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Bag
• Labels: patch, performance

Environment

any

• Assignee: Unassigned
• Reporter: Adrian Nistor
• Created: 03/Jun/13 22:59
• Updated: 09/Nov/14 14:31
• Resolved: 09/Jun/13 18:35

Description

The problem appears in version 3.2.1 and in revision 1489197. I
attached a one-line patch that fixes it.

In method "AbstractMapBag.containsAll", the loop over
"other.uniqueSet()" should return immediately after "result" becomes
"false", because "result = result && contains;" can never become
"true" again. All the iterations after "result" becomes "false" do
not perform any useful work, at best they just set "result" again to
"false".