[COLLECTIONS-453] findBugs Warnings: several classes in package functors may expose their internal representation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.1
• Fix Version/s: 4.0-alpha1, 4.0
• Assignee: Unassigned
• Reporter: Thomas Neidhart
• Created: 27/Apr/13 12:23
• Updated: 09/Nov/14 14:31
• Resolved: 05/May/13 16:16

Description

Several classes (e.g. SwitchTransformer) take in their constructor an array as input which is not copied/cloned.
Thus its internal representation may be changed externally.

The corresponding factory methods do copy the input arguments thus we have two choices:

• move the copy from the factory methods to the ctors
• make the ctors private to prevent their use