[COLLECTIONS-372] ComparatorUtils.transformedComparator wrongly typed (generics)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.x
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Comparator
• Labels: patch

Environment

n/a

• Assignee: Unassigned
• Reporter: HaveNone
• Created: 18/Mar/11 12:45
• Updated: 09/Nov/14 14:31
• Resolved: 06/Mar/13 19:52

Description

ComparatorUtils.transformedComparator is currently typed as follows :

public static <I,O> Comparator<O> transformedComparator(Comparator<I> comparator, Transformer<I, O> transformer)

It should be typed as follows so that is can be used without removing generics typing:
public static <I,O> Comparator<I> transformedComparator(Comparator<O> comparator, Transformer<I, O> transformer)

Here is a unit test for it :
Transformer<Integer, String> itosTransformer = TransformerUtils.stringValueTransformer();
Comparator<Integer> c = new Comparator<Integer>() {

@Override
public int compare(Integer o1, Integer o2)

{ return o1.compareTo(o2); }

};
Comparator<String> stringComparator = ComparatorUtils.transformedComparator(c, itosTransformer);

stringComparator.compare("string1", "string2");

Issue Links

• is related to: COLLECTIONS-333 Generic versions of Transformed* classes