[COLLECTIONS-340] NOPClosure has a broken equals method

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Functor
• Assignee: Unassigned
• Reporter: Goran Hacek
• Created: 14/Oct/09 11:45
• Updated: 09/Nov/14 14:31
• Resolved: 28/Feb/13 19:55

Description

Equals method of NOPClosure class doesn't follow objects equals contract. It isn't symmetric nor transitive and it is just plain wrong.

Following code evaluates to true on most (if not all) JVM implementations:

 NOPClosure.INSTANCE.equals(new Integer(System.identityHashCode(NOPClosure.INSTANCE)))