[COLLECTIONS-318] CollectionUtils.size(Object object) has impossible null check

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Collection
• Assignee: Unassigned
• Reporter: Sebb
• Created: 16/Feb/09 19:28
• Updated: 09/Nov/14 14:31
• Resolved: 28/Feb/13 19:58

Description

CollectionUtils.size(Object object) has impossible null check:

    public static int size(Object object) {
        if (object == null) {
            return 0;
        }
...
        } else if (object == null) {
            throw new IllegalArgumentException("Unsupported object type: null");
...

The Javadoc specifically says that null is allowed, so I think the object == null clause needs to be removed - it can never be true, and is just confusing.