Commons Collections
  1. Commons Collections
  2. COLLECTIONS-281

Change maven build to create Collections Test Framework jar

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        294d 2h 58m 1 Henri Yandell 24/Oct/08 03:36
        Closed Closed Reopened Reopened
        1588d 16h 20m 1 Thomas Neidhart 28/Feb/13 19:57
        Reopened Reopened Resolved Resolved
        6s 1 Thomas Neidhart 28/Feb/13 19:57
        Resolved Resolved Closed Closed
        1002d 1h 13m 1 Thomas Neidhart 27/Nov/15 21:11
        Thomas Neidhart made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Thomas Neidhart made changes -
        Fix Version/s 4.0 [ 12314511 ]
        Thomas Neidhart made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Thomas Neidhart made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Thomas Neidhart made changes -
        Fix Version/s 4.0 [ 12314511 ]
        Fix Version/s 4.0-beta-1 [ 12311987 ]
        Mark Thomas made changes -
        Workflow jira [ 12420185 ] Default workflow, editable Closed status [ 12607028 ]
        Henri Yandell made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Hide
        Henri Yandell added a comment -

        Doesn't look like I'm going to do that in fact. I'm fine with doing 1.3 and have committed that in r707529.

        Show
        Henri Yandell added a comment - Doesn't look like I'm going to do that in fact. I'm fine with doing 1.3 and have committed that in r707529.
        Henri Yandell made changes -
        Assignee Henri Yandell [ bayard ]
        Hide
        Henri Yandell added a comment -

        I'll check to see if we compile on 1.2 still, and maybe 1.1 too if I get that installed. Then we can have the info to make the decision.

        Show
        Henri Yandell added a comment - I'll check to see if we compile on 1.2 still, and maybe 1.1 too if I get that installed. Then we can have the info to make the decision.
        Hide
        Niall Pemberton added a comment -

        I applied all of the patch - so AFAIC its done:

        http://svn.apache.org/viewvc?view=rev&revision=638061

        Running the three builds (ant, m1 & m2) the source/target options used are inconsistent:

        • Ant: doesn't use any source/target options when compiling, but has 1.2 in the jar's manifest for X-Compile-Source-JDK/X-Compile-Target-JDK (hard coded in src/conf/MANIFEST.MF)
        • m1: uses 1.3/1.1 values for source/target options
        • m2: uses 1.3/1.3 values for source/target options

        IMO we should just use 1.3 for both source/target as1.2 is so old I see no reason to attempt to support it (anyone wanting 1.2 compataible versions will have to stay on an older release)

        Show
        Niall Pemberton added a comment - I applied all of the patch - so AFAIC its done: http://svn.apache.org/viewvc?view=rev&revision=638061 Running the three builds (ant, m1 & m2) the source/target options used are inconsistent: Ant: doesn't use any source/target options when compiling, but has 1.2 in the jar's manifest for X-Compile-Source-JDK/X-Compile-Target-JDK (hard coded in src/conf/MANIFEST.MF) m1: uses 1.3/1.1 values for source/target options m2: uses 1.3/1.3 values for source/target options IMO we should just use 1.3 for both source/target as1.2 is so old I see no reason to attempt to support it (anyone wanting 1.2 compataible versions will have to stay on an older release)
        Hide
        Henri Yandell added a comment -

        What's the status of this one Niall? I saw you'd applied part of it.

        Show
        Henri Yandell added a comment - What's the status of this one Niall? I saw you'd applied part of it.
        Henri Yandell made changes -
        Fix Version/s 3.3 [ 12311987 ]
        Niall Pemberton made changes -
        Field Original Value New Value
        Attachment COLLECTIONS-281-build-testframework.patch [ 12372474 ]
        Hide
        Niall Pemberton added a comment -

        Attaching a patch which extracts the creation of the Test Framework into a separate ant build file (build-testframework.xml). Change the ant, m1 and m2 builds to all use the same ant build file to create the test framework jar.

        Show
        Niall Pemberton added a comment - Attaching a patch which extracts the creation of the Test Framework into a separate ant build file (build-testframework.xml). Change the ant, m1 and m2 builds to all use the same ant build file to create the test framework jar.
        Niall Pemberton created issue -

          People

          • Assignee:
            Henri Yandell
            Reporter:
            Niall Pemberton
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development