Commons Collections
  1. Commons Collections
  2. COLLECTIONS-281

Change maven build to create Collections Test Framework jar

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)

        Activity

        Hide
        Niall Pemberton added a comment -

        Attaching a patch which extracts the creation of the Test Framework into a separate ant build file (build-testframework.xml). Change the ant, m1 and m2 builds to all use the same ant build file to create the test framework jar.

        Show
        Niall Pemberton added a comment - Attaching a patch which extracts the creation of the Test Framework into a separate ant build file (build-testframework.xml). Change the ant, m1 and m2 builds to all use the same ant build file to create the test framework jar.
        Hide
        Henri Yandell added a comment -

        What's the status of this one Niall? I saw you'd applied part of it.

        Show
        Henri Yandell added a comment - What's the status of this one Niall? I saw you'd applied part of it.
        Hide
        Niall Pemberton added a comment -

        I applied all of the patch - so AFAIC its done:

        http://svn.apache.org/viewvc?view=rev&revision=638061

        Running the three builds (ant, m1 & m2) the source/target options used are inconsistent:

        • Ant: doesn't use any source/target options when compiling, but has 1.2 in the jar's manifest for X-Compile-Source-JDK/X-Compile-Target-JDK (hard coded in src/conf/MANIFEST.MF)
        • m1: uses 1.3/1.1 values for source/target options
        • m2: uses 1.3/1.3 values for source/target options

        IMO we should just use 1.3 for both source/target as1.2 is so old I see no reason to attempt to support it (anyone wanting 1.2 compataible versions will have to stay on an older release)

        Show
        Niall Pemberton added a comment - I applied all of the patch - so AFAIC its done: http://svn.apache.org/viewvc?view=rev&revision=638061 Running the three builds (ant, m1 & m2) the source/target options used are inconsistent: Ant: doesn't use any source/target options when compiling, but has 1.2 in the jar's manifest for X-Compile-Source-JDK/X-Compile-Target-JDK (hard coded in src/conf/MANIFEST.MF) m1: uses 1.3/1.1 values for source/target options m2: uses 1.3/1.3 values for source/target options IMO we should just use 1.3 for both source/target as1.2 is so old I see no reason to attempt to support it (anyone wanting 1.2 compataible versions will have to stay on an older release)
        Hide
        Henri Yandell added a comment -

        I'll check to see if we compile on 1.2 still, and maybe 1.1 too if I get that installed. Then we can have the info to make the decision.

        Show
        Henri Yandell added a comment - I'll check to see if we compile on 1.2 still, and maybe 1.1 too if I get that installed. Then we can have the info to make the decision.
        Hide
        Henri Yandell added a comment -

        Doesn't look like I'm going to do that in fact. I'm fine with doing 1.3 and have committed that in r707529.

        Show
        Henri Yandell added a comment - Doesn't look like I'm going to do that in fact. I'm fine with doing 1.3 and have committed that in r707529.

          People

          • Assignee:
            Henri Yandell
            Reporter:
            Niall Pemberton
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development