[COLLECTIONS-231] Not return the base interface on decorate

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Map
• Assignee: Unassigned
• Reporter: Torsten Curdt
• Created: 30/Oct/06 10:43
• Updated: 09/Nov/14 14:31
• Resolved: 31/Jul/12 18:23

Description

At the moment I don't see a reason why the static "decorate" method does not return ListOrderedMap but just the base interface OrderedMap.

I want to decorate a Map to be a ListOrderedMap but due to the fact that the constructor is not visible and decorate only returns the base interface OrderedMap an unnecessary cast is required.

ListOrderedMap map = (ListOrderedMap)ListOrderedMap.decorate(new MyMap());

As the decorate method is static and not part of any interface it should be fine to return the real type instead of the base. Otherwise I'd suggest to make the constructor visible. From the API POV It is not really understandable why this

ListOrderedMap map = new ListOrderedMap();

is fine and creates a HashMap under the hood while this

ListOrderedMap map = new ListOrderedMap(new MyMap()));

is not ok.