[COLLECTIONS-182] [collections] Change CollectionUtils.forAllDo to return the Closure

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1
• Fix Version/s: 4.0-alpha1, 4.0

Environment

Operating System: All
Platform: All

• Bugzilla Id: 35955
• Assignee: Unassigned
• Reporter: Jim Cakalic
• Created: 01/Aug/05 10:21
• Updated: 09/Nov/14 14:31
• Resolved: 28/Feb/13 20:25

Description

I frequently use CollectionUtils.forAllDo with a Closure that determines some
kind of aggregate value across the members of the Collection. For example, and
this is entirely manufactured, say I have an Order with a collection of
LineItems. Order might use a SumClosure to count the number of actual items (not
LineItem objects) on the Order or to compute the sum of the LineItems cost. It
would be convenient in these cases if I could use the return of forAllDo to
chain method calls like this:

public BigDecimal getTotal()

{ return CollectionUtils.forAllDo(lineItems, new SumTotalClosure()).total(); }

As it is, I have to make do with the somewhat less compact:

public BigDecimal getTotal()

{ SumTotalClosure closure = new SumTotalClosure(); CollectionUtils.forAllDo(lineItems, closure); return closure.total(); }

Thanks for considering it.

Regards,
Jim Cakalic