[COLLECTIONS-104] [collections] Only last element is removeable when CircularFifoBuffer is full

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1

Environment

Operating System: Linux
Platform: PC

• Bugzilla Id: 33071
• Assignee: Unassigned
• Reporter: Amir Tahvildaran
• Created: 13/Jan/05 03:30
• Updated: 15/Mar/08 21:36
• Resolved: 15/Mar/08 21:36

Description

If the circular fifo buffer is full and you remove an item, that is not the last
one, it breaks.

code example:

import java.io.*;
import org.apache.commons.collections.buffer.*;

class Stub {
public static void main(String[] args)

{ CircularFifoBuffer fifo = new CircularFifoBuffer(5); System.out.println(fifo); fifo.add(new String("1")); System.out.println(fifo); fifo.add(new String("2")); System.out.println(fifo); fifo.add(new String("3")); System.out.println(fifo); fifo.add(new String("4")); System.out.println(fifo); System.out.println("adding 5"); fifo.add(new String("5")); System.out.println(fifo); String six = new String("6"); System.out.println("adding 6"); fifo.add(six); System.out.println(fifo); /* uncomment the following block to avoid problem System.out.println("fifo.isFull?:"+fifo.isFull()); System.out.println("removing 6"); fifo.remove(new String("6")); System.out.println(fifo); */ System.out.println("fifo.isFull?:"+fifo.isFull()); System.out.println("removing 3"); fifo.remove(new String("3")); System.out.println(fifo); System.out.println("removing 4"); fifo.remove(new String("4")); System.out.println(fifo); System.out.println("clearing"); fifo.clear(); System.out.println("removing 4"); fifo.remove(new String("4")); System.out.println(fifo); }

}

==============

output busted:

[]
[1]
[1, 2]
[1, 2, 3]
[1, 2, 3, 4]
adding 5
[1, 2, 3, 4, 5]
adding 6
[2, 3, 4, 5, 6]
fifo.isFull?:true
removing 3
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: -1
at
org.apache.commons.collections.buffer.BoundedFifoBuffer$1.remove(BoundedFifoBuffer.java:347)
at java.util.AbstractCollection.remove(AbstractCollection.java:255)
at Stub.main(Stub.java:40)