[CODEC-99] Base64.encodeBase64String() shouldn't chunk

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.5
• Assignee: Unassigned
• Reporter: Julius Davies
• Created: 27/Mar/10 04:29
• Updated: 10/Nov/11 18:10
• Resolved: 23/Jan/11 05:56

Description

Base64.encodeBase64String() shouldn't chunk.

Change this:

public static String encodeBase64String(byte[] binaryData) {
    return StringUtils.newStringUtf8(encodeBase64(binaryData, true));
}

To this:

public static String encodeBase64String(byte[] binaryData) {
    return StringUtils.newStringUtf8(encodeBase64(binaryData, false));
}

This will fix the following tests ggregory added a few minutes ago:

//assertEquals("Zg==", Base64.encodeBase64String(StringUtils.getBytesUtf8("f")));
//assertEquals("Zm8=", Base64.encodeBase64String(StringUtils.getBytesUtf8("fo")));
//assertEquals("Zm9v", Base64.encodeBase64String(StringUtils.getBytesUtf8("foo")));
//assertEquals("Zm9vYg==", Base64.encodeBase64String(StringUtils.getBytesUtf8("foob")));
//assertEquals("Zm9vYmE=", Base64.encodeBase64String(StringUtils.getBytesUtf8("fooba")));
//assertEquals("Zm9vYmFy", Base64.encodeBase64String(StringUtils.getBytesUtf8("foobar")));