Uploaded image for project: 'Commons Codec'
  1. Commons Codec
  2. CODEC-72

Soundex and RefinedSoundex issues with character arrays

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.4
    • None

    Description

      Soundex and RefinedSoundex both have public US_ENGLISH_MAPPING char arrays. These don't appear to be used externally, so should be made private - or at least package protected.

      Also, the class constructors store externally mutable char arrays; it would be better if these were copied.

      Patch to follow.

      Attachments

        1. soundex.patch
          6 kB
          Sebb

        Activity

          People

            Unassigned Unassigned
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: