[COCOON3-46] URLConnectionUtils.closeQuietly() complains loudly if servletConnection == null

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-2
• Fix Version/s: 3.0.0-alpha-3
• Component/s: cocoon-pipeline
• Assignee: Steven Dolg
• Reporter: Jos Snellings
• Created: 05/Dec/09 08:41
• Updated: 09/Dec/09 15:55
• Resolved: 09/Dec/09 15:55

Description

finally clause in URLResponse method execute()
contains call to URLConnectionUtils.closeQuietly.

If servletConnection = this.url.openConnection(); fails, servletConnection is null.

In that case closeQuietly causes a stacktrace to be output.

Solution is if (servletConnection != null) URLConnectionUtils.closeQuietly(servletConnection);, guard the call with a test,
or even better, take into account in closeQuietly that the input parameter may be null.