Uploaded image for project: 'Cocoon 3'
  1. Cocoon 3
  2. COCOON3-46

URLConnectionUtils.closeQuietly() complains loudly if servletConnection == null

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha-2
    • Fix Version/s: 3.0.0-alpha-3
    • Component/s: cocoon-pipeline
    • Labels:
      None

      Description

      finally clause in URLResponse method execute()
      contains call to URLConnectionUtils.closeQuietly.

      If servletConnection = this.url.openConnection(); fails, servletConnection is null.

      In that case closeQuietly causes a stacktrace to be output.

      Solution is if (servletConnection != null) URLConnectionUtils.closeQuietly(servletConnection);, guard the call with a test,
      or even better, take into account in closeQuietly that the input parameter may be null.

        Attachments

          Activity

            People

            • Assignee:
              steven.dolg Steven Dolg
              Reporter:
              jos.snellings@upperware.biz Jos Snellings
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: