Cocoon 3
  1. Cocoon 3
  2. COCOON3-16

Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha-1
    • Fix Version/s: 3.0.0-alpha-2
    • Component/s: cocoon-pipeline
    • Labels:
      None

      Description

      The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
      1. consumer.patch
        5 kB
        Steven Dolg

        Activity

        Hide
        Steven Dolg added a comment -
        Patch applied with minor modifications due to changes that occurred meanwhile.
        Show
        Steven Dolg added a comment - Patch applied with minor modifications due to changes that occurred meanwhile.
        Hide
        Carsten Ziegeler added a comment -
        We should use the SAXBuffer from cocoon-xml instead and do we really need NullXMLConsumer?
        I think we can go without an XMLConsumer completly and just really on ContentHandler. I'll commit with an RT about that in the list.
        Show
        Carsten Ziegeler added a comment - We should use the SAXBuffer from cocoon-xml instead and do we really need NullXMLConsumer? I think we can go without an XMLConsumer completly and just really on ContentHandler. I'll commit with an RT about that in the list.
        Hide
        Steven Dolg added a comment -
        Actually I'm not sure about those classes inheriting from AbstractPipelineComponent.

        While technically it would make no difference (no additional interfaces implemented nor anything else), this somehow appears strange to me.
        Mostly because those are no real pipeline components.

        I guess this will need some more changes/improvements, but currently I have no idea what or how...
        Show
        Steven Dolg added a comment - Actually I'm not sure about those classes inheriting from AbstractPipelineComponent. While technically it would make no difference (no additional interfaces implemented nor anything else), this somehow appears strange to me. Mostly because those are no real pipeline components. I guess this will need some more changes/improvements, but currently I have no idea what or how...
        Hide
        Steven Dolg added a comment -
        Patch without formatting changes...
        Show
        Steven Dolg added a comment - Patch without formatting changes...
        Hide
        Andreas Pieber added a comment -
        Looks quite nice, but wouldn't it better to inherit the following classes from AbstractPipelineComponent?

        o.a.c.p.u.SaxBuffer
        o.a.c.p.u.NullXMLConsumer
        Show
        Andreas Pieber added a comment - Looks quite nice, but wouldn't it better to inherit the following classes from AbstractPipelineComponent? o.a.c.p.u.SaxBuffer o.a.c.p.u.NullXMLConsumer
        Hide
        Steven Dolg added a comment -
        Yes, just checked that - sorry for that.

        I guess I'll make a patch without formatting changes...
        Show
        Steven Dolg added a comment - Yes, just checked that - sorry for that. I guess I'll make a patch without formatting changes...
        Hide
        Grzegorz Kossakowski added a comment -
        Steven, I can see some other changes to SaxBuffer. Are they formatting-only?
        Show
        Grzegorz Kossakowski added a comment - Steven, I can see some other changes to SaxBuffer. Are they formatting-only?
        Hide
        Steven Dolg added a comment -
        Changed o.a.c.p.c.Consumer to extend o.a.c.p.c.PipelineComponent and added the necessary methods to the implementing classes.
        Show
        Steven Dolg added a comment - Changed o.a.c.p.c.Consumer to extend o.a.c.p.c.PipelineComponent and added the necessary methods to the implementing classes.

          People

          • Assignee:
            Steven Dolg
            Reporter:
            Steven Dolg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development