Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0-beta-1
    • Fix Version/s: 3.0.0-beta-1
    • Component/s: cocoon-pipeline, cocoon-sax
    • Labels:
      None

      Description

      We need to implements CachingPipelineComponent. Like older Cocoon versions, we can ask for the SourceValidity of the implicated resources.
      1. ResponseHeaderCollector.diff
        1 kB
        Javier Puerto
      2. COCOON3-100.diff
        16 kB
        Javier Puerto

        Activity

        Hide
        Francesco Chicchiriccò added a comment - - edited
        This issue can be temporarily solved by applying the same kind of approach from COCOON3-102.

        A proper fix will happen as for COOON3-117.
        Show
        Francesco Chicchiriccò added a comment - - edited This issue can be temporarily solved by applying the same kind of approach from COCOON3-102 . A proper fix will happen as for COOON3-117.
        Hide
        Hudson added a comment -
        Integrated in Cocoon-trunk #205 (See [https://builds.apache.org/job/Cocoon-trunk/205/])
            [COCOON3-102] Applying (and reworking a bit) the proposed patch for COCOON3-100, replacing URLCacheKey with URLConnectionUtils.getLastModified() (Revision 1356609)

             Result = SUCCESS
        ilgrosso : http://svn.apache.org/viewvc/?view=rev&rev=1356609
        Files :
        * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/jaxb/JAXBGenerator.java
        * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/jaxb/ObjectCacheKey.java
        * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CachedCacheKey.java
        * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CachedCacheValue.java
        * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CompoundCacheKey.java
        * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/ObjectCacheKey.java
        * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/TimestampCacheKey.java
        * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/URLListCacheKey.java
        * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/util/URLConnectionUtils.java
        * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/sitemap.xmap
        * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/SchemaProcessorTransformer.java
        * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XIncludeTransformer.java
        * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XMLGenerator.java
        * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XSLTTransformer.java
        * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/util/URLUtils.java
        * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/component/FileReaderComponent.java
        * /cocoon/cocoon3/trunk/cocoon-stringtemplate/src/main/java/org/apache/cocoon/stringtemplate/StringTemplateGenerator.java
        * /cocoon/cocoon3/trunk/cocoon-stringtemplate/src/main/java/org/apache/cocoon/stringtemplate/StringTemplateReader.java
        Show
        Hudson added a comment - Integrated in Cocoon-trunk #205 (See [ https://builds.apache.org/job/Cocoon-trunk/205/ ])     [ COCOON3-102 ] Applying (and reworking a bit) the proposed patch for COCOON3-100 , replacing URLCacheKey with URLConnectionUtils.getLastModified() (Revision 1356609)      Result = SUCCESS ilgrosso : http://svn.apache.org/viewvc/?view=rev&rev=1356609 Files : * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/jaxb/JAXBGenerator.java * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/jaxb/ObjectCacheKey.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CachedCacheKey.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CachedCacheValue.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CompoundCacheKey.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/ObjectCacheKey.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/TimestampCacheKey.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/URLListCacheKey.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/util/URLConnectionUtils.java * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/sitemap.xmap * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/SchemaProcessorTransformer.java * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XIncludeTransformer.java * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XMLGenerator.java * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XSLTTransformer.java * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/util/URLUtils.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/component/FileReaderComponent.java * /cocoon/cocoon3/trunk/cocoon-stringtemplate/src/main/java/org/apache/cocoon/stringtemplate/StringTemplateGenerator.java * /cocoon/cocoon3/trunk/cocoon-stringtemplate/src/main/java/org/apache/cocoon/stringtemplate/StringTemplateReader.java
        Hide
        Javier Puerto added a comment -
        Working on this patch I've unified how ResponseHeaderCollector retrieves the Long values.
        Show
        Javier Puerto added a comment - Working on this patch I've unified how ResponseHeaderCollector retrieves the Long values.
        Hide
        Javier Puerto added a comment -
        I've moved the ObjectCacheKey from cocoon-optional to cocoon-pipeline, please do a svn move instead.

        The implementation could be better in performance because we need to open connections to the resources to get the "Last-Modified" header value but it's fine for "file://" resources. Maybe an internal expires value?
        Show
        Javier Puerto added a comment - I've moved the ObjectCacheKey from cocoon-optional to cocoon-pipeline, please do a svn move instead. The implementation could be better in performance because we need to open connections to the resources to get the "Last-Modified" header value but it's fine for "file://" resources. Maybe an internal expires value?
        Hide
        Javier Puerto added a comment -
        Add CachedCacheKey class and URLCacheKey.
        Move ObjectCacheKey from cocoon-optional.
        Add caching support to IncludeTransformer.
        Modify IncludeTransformer pipeline in cocoon-sample
        Show
        Javier Puerto added a comment - Add CachedCacheKey class and URLCacheKey. Move ObjectCacheKey from cocoon-optional. Add caching support to IncludeTransformer. Modify IncludeTransformer pipeline in cocoon-sample

          People

          • Assignee:
            Unassigned
            Reporter:
            Javier Puerto
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development