[COCOON-2167] Default value of validate attribute of submit widget has changed from true to false

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 2.1.11
• Component/s: Blocks: Forms
• Urgency: Normal
• Affects version (Component): Blocks: Forms - 1.0.0-RC2
• Fix version (Component): Blocks: Forms - 1.0.0-RC3-SNAPSHOT
• Assignee: Jörg Heinicke
• Reporter: Jörg Heinicke
• Created: 12/Feb/08 00:55
• Updated: 12/Feb/08 12:57
• Resolved: 12/Feb/08 12:57

Description

http://marc.info/?l=xml-cocoon-dev&m=120277341318228&w=4

Hello

I noticed a change in behavior of cforms lately. the submit widget now
has "false" as default value for the "validate" attribute (opposed to the
documenation which says, true is the default value). This really breaks
our application. After backporting vadim's fixes for the concurrency bugs
we discovered to cforms 2.1.10, we also "migrated" this new behavior to
our cforms version.

here is the code, which has an extra if statement in comparision to
2.1.10.

public final class SubmitDefinitionBuilder extends ActionDefinitionBuilder
{

    public WidgetDefinition buildWidgetDefinition(Element widgetElement, WidgetDefinitionBuilderContext context)
    throws Exception {
        SubmitDefinition definition = new SubmitDefinition();
        setupDefinition(widgetElement, definition, context);

        // parse "@validate"
        if (widgetElement.hasAttribute("validate")) {
            definition.setValidateForm(DomHelper.getAttributeAsBoolean(widgetElement, "validate", true));
        }

        definition.makeImmutable();
        return definition;
    }
}

Is there any reason, why the behavior was changed and if it was a
accident, could someone revert the code inside the repos to the old
behavior?

thanx alot!

Gabriel