[COCOON-2078] Profiling pipelines must not implement Configurable interface as they are already Parameterizable

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.2
• Fix Version/s: 2.2
• Component/s: Blocks: Profiler
• Other Info: Patch available
• Assignee: Grzegorz Kossakowski
• Reporter: Alexander Klimetschek
• Created: 21/Jun/07 14:49
• Updated: 11/Jul/07 12:56
• Resolved: 11/Jul/07 12:56

Description

The most-recent change to both Profiling pipelines (revision 503964 in February 07) added the configuration "sax-stream" option and this was done by additionally implementing the Configurable interface. But as in BaseCachingProcessingPipeline (a base class) the interface Parameterizable is already implemented, and an Avalon component can be either one or the other [1], this is a bug. It's critical since the cache is retrieved in BaseCachingProcessingPipeline.parameterize(), but as Configurable has precedence over Parameterizable [2], the cache will be null and a NPE will be thrown during generation phase.

[1] http://excalibur.apache.org/apidocs/org/apache/avalon/framework/parameters/Parameterizable.html
[2] http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/core/container/spring/avalon/AvalonBeanPostProcessor.java?view=markup, see method postProcessBeforeInitialization()