Cocoon
  1. Cocoon
  2. COCOON-2036

Throw an exception when circular dependencies in servlet connections are detected.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: None
    • Labels:
      None
    • Affects version (Component):
      Servlet Service Framework - 1.0.0-RC1
    • Fix version (Component):
      Servlet Service Framework - 1.0.0-RC2-dev

      Description

      Circular dependencies in servlet connections lead to a Spring exception [1] in [2] that does not provide any help. The previous implementation (block:) did allow circular dependencies because they were not handled by spring but by custom code.

      Solution would be either to allow them (probably difficult to implement with spring) or, if not, to provide a helpful warning message, that skips this problem. The latter could be a check for embeddedServlet==null and, if not, throw an exception saying "you might have a circular dependency in <servlet-foobar>".

      ---

      [1]:

      The exception is thrown after ServletFactoryBean.getObject() tries to create a proxy for the embeddedServlet, which is null in the case of a circular dependency (one of the circle endpoints is created, but the other will be null).

      Caused by: org.springframework.aop.framework.AopConfigException: Can't proxy null object
              at org.springframework.aop.framework.ProxyFactory.<init>(ProxyFactory.java:49)
              at org.apache.cocoon.servletservice.spring.ServletFactoryBean.getObject(ServletFactoryBean.java:194)
              at org.springframework.beans.factory.support.AbstractBeanFactory.getObjectFromFactoryBean(AbstractBeanFactory.java:1211)

      [2]:
          public Object getObject() throws Exception {
              ProxyFactory proxyFactory = new ProxyFactory(this.embeddedServlet);
              proxyFactory.addAdvice(new ServiceInterceptor());
              if (this.mountPath != null) {
                  proxyFactory.addAdvisor(new MountableMixinAdvisor());
              }
              proxyFactory.addAdvisor(new ServletServiceContextMixinAdvisor());
              return proxyFactory.getProxy();
          }

        Issue Links

          Activity

          Alexander Klimetschek created issue -
          Grzegorz Kossakowski made changes -
          Field Original Value New Value
          Link This issue is related to COCOON-2038 [ COCOON-2038 ]
          Alexander Klimetschek made changes -
          Grzegorz Kossakowski made changes -
          Component/s - OSGi integration [ 12311920 ]
          Component/s - Servlet service framework [ 12310706 ]
          Grzegorz Kossakowski made changes -
          Component/s - OSGi integration [ 12311920 ]
          Component/s - Servlet service framework [ 12310706 ]
          Grzegorz Kossakowski made changes -
          Assignee Grzegorz Kossakowski [ grek ]
          Grzegorz Kossakowski made changes -
          Summary Handle circular dependencies in servlet connections Throw an exception when circular dependencies in servlet connections are detected.
          Priority Major [ 3 ] Minor [ 4 ]
          Affects version (Component) Parent values: Servlet Service Framework(10175). Level 1 values: 1.0.0-RC1(10313).
          Fix version (Component) Parent values: Servlet Service Framework(10247). Level 1 values: 1.0.0-RC2-dev(10316).
          Grzegorz Kossakowski made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Grzegorz Kossakowski
              Reporter:
              Alexander Klimetschek
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development