Cocoon
  1. Cocoon
  2. COCOON-1924

[PATCH] cocoon-fop-ng-block introduces support for FOP 0.92beta and later

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Blocks: FOP
    • Labels:
      None
    • Other Info:
      Patch available

      Description

      This patch was written by Jeremias Märki (FOP Developer) and Lars Trieloff. It uses the new FOP API which simplifies the Serializer code greatly and allows for relative addressing of resources using the URIResolver framework. This patch should close COCOON-1797, COCOON-1795 and COCOON-531

      It depends on the addition of the FOP pom to the central repository which is in the works.
      1. cocoon-fop-ng-block.patch
        18 kB
        Lars Trieloff
      2. xmlgraphics-maven-repo.tar.gz
        1.77 MB
        Lars Trieloff
      3. fop1
        1 kB
        Jean-Baptiste Quenot

        Activity

        Hide
        Lars Trieloff added a comment -
        In order to keep history of the files, cocoon-fop-impl has to be copied to cocoon-fop-ng-impl and cocoon-fop-sample to cocoon-fop-ng-sample, only afterwards the patch can be applied. Following files are affected by the patch:

        A + blocks/cocoon-fop/cocoon-fop-ng-impl
        D + blocks/cocoon-fop/cocoon-fop-ng-impl/src/main/java/org/apache/cocoon/components
        A blocks/cocoon-fop/cocoon-fop-ng-impl/src/main/java/org/apache/cocoon/serialization/FOPNGSerializer.java
        D + blocks/cocoon-fop/cocoon-fop-ng-impl/src/main/java/org/apache/cocoon/serialization/FOPSerializer.java
        M + blocks/cocoon-fop/cocoon-fop-ng-impl/src/main/resources/META-INF/legacy/sitemap-additions/cocoon-fop.xmap
        M + blocks/cocoon-fop/cocoon-fop-ng-impl/pom.xml
        A + blocks/cocoon-fop/cocoon-fop-ng-sample
        M + blocks/cocoon-fop/cocoon-fop-ng-sample/src/main/resources/COB-INF/fop.xsamples
        M + blocks/cocoon-fop/cocoon-fop-ng-sample/pom.xml
        M blocks/cocoon-fop/pom.xml
        Show
        Lars Trieloff added a comment - In order to keep history of the files, cocoon-fop-impl has to be copied to cocoon-fop-ng-impl and cocoon-fop-sample to cocoon-fop-ng-sample, only afterwards the patch can be applied. Following files are affected by the patch: A + blocks/cocoon-fop/cocoon-fop-ng-impl D + blocks/cocoon-fop/cocoon-fop-ng-impl/src/main/java/org/apache/cocoon/components A blocks/cocoon-fop/cocoon-fop-ng-impl/src/main/java/org/apache/cocoon/serialization/FOPNGSerializer.java D + blocks/cocoon-fop/cocoon-fop-ng-impl/src/main/java/org/apache/cocoon/serialization/FOPSerializer.java M + blocks/cocoon-fop/cocoon-fop-ng-impl/src/main/resources/META-INF/legacy/sitemap-additions/cocoon-fop.xmap M + blocks/cocoon-fop/cocoon-fop-ng-impl/pom.xml A + blocks/cocoon-fop/cocoon-fop-ng-sample M + blocks/cocoon-fop/cocoon-fop-ng-sample/src/main/resources/COB-INF/fop.xsamples M + blocks/cocoon-fop/cocoon-fop-ng-sample/pom.xml M blocks/cocoon-fop/pom.xml
        Hide
        Lars Trieloff added a comment -
        These files, put into a local maven repository make it possible to build the new fop-ng-block.
        Show
        Lars Trieloff added a comment - These files, put into a local maven repository make it possible to build the new fop-ng-block.
        Hide
        Bertrand Delacretaz added a comment -
        According to the discussions in

        http://mail-archives.apache.org/mod_mbox/cocoon-dev/200506.mbox/%3c42A9D1D7.4030008@reverycodes.com%3e

        the package name will be changed to

          org.apache.cocoon.blocks.fop

        Show
        Bertrand Delacretaz added a comment - According to the discussions in http://mail-archives.apache.org/mod_mbox/cocoon-dev/200506.mbox/%3c42A9D1D7.4030008@reverycodes.com%3e the package name will be changed to   org.apache.cocoon.blocks.fop
        Hide
        Jean-Baptiste Quenot added a comment -
        Adding the artifacts on people.apache.org in m2-snapshot-repository
        Show
        Jean-Baptiste Quenot added a comment - Adding the artifacts on people.apache.org in m2-snapshot-repository
        Hide
        Jean-Baptiste Quenot added a comment -
        [INFO] ------------------------------------------------------------------------
        [INFO] FOP Block [modules] ................................... SUCCESS [37.222s]
        [INFO] FOP Block Implementation .............................. SUCCESS [48.851s]
        [INFO] FOP Block Samples ..................................... SUCCESS [0.812s]
        [INFO] FOP 0.92 Block Implementation ......................... SUCCESS [31.003s]
        [INFO] FOP NG Block Samples .................................. SUCCESS [0.289s]
        [INFO] ------------------------------------------------------------------------
        [INFO] ------------------------------------------------------------------------
        [INFO] BUILD SUCCESSFUL
        [INFO] ------------------------------------------------------------------------
        [INFO] Total time: 1 minute 59 seconds
        [INFO] Finished at: Mon Oct 02 17:13:58 CEST 2006
        [INFO] Final Memory: 9M/18M
        [INFO] ------------------------------------------------------------------------
        Show
        Jean-Baptiste Quenot added a comment - [INFO] ------------------------------------------------------------------------ [INFO] FOP Block [modules] ................................... SUCCESS [37.222s] [INFO] FOP Block Implementation .............................. SUCCESS [48.851s] [INFO] FOP Block Samples ..................................... SUCCESS [0.812s] [INFO] FOP 0.92 Block Implementation ......................... SUCCESS [31.003s] [INFO] FOP NG Block Samples .................................. SUCCESS [0.289s] [INFO] ------------------------------------------------------------------------ [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESSFUL [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1 minute 59 seconds [INFO] Finished at: Mon Oct 02 17:13:58 CEST 2006 [INFO] Final Memory: 9M/18M [INFO] ------------------------------------------------------------------------
        Hide
        Jean-Baptiste Quenot added a comment -
        Also need this patch
        Show
        Jean-Baptiste Quenot added a comment - Also need this patch
        Hide
        Jean-Baptiste Quenot added a comment -
        Adding a dependency from cocoon-fop-sample to cocoon-batik-impl... unless the dependency needs to be on -impl?
        Show
        Jean-Baptiste Quenot added a comment - Adding a dependency from cocoon-fop-sample to cocoon-batik-impl... unless the dependency needs to be on -impl?
        Hide
        Jean-Baptiste Quenot added a comment -
        Problem when using context://resources/images/cocoon.gif

        btpool0-2 DEBUG FOP - File not found: file:/home/jbq/var/repos/cocoon/trunk/core/cocoon-webapp/target/cocoon-webapp/samples/fop/misc/context://resources/images/cocoon.gif
        btpool0-2 ERROR fo.FONode - Image not available: /home/jbq/var/repos/cocoon/trunk/core/cocoon-webapp/target/cocoon-webapp/samples/fop/misc/context://resources/images/cocoon.gif
        Show
        Jean-Baptiste Quenot added a comment - Problem when using context://resources/images/cocoon.gif btpool0-2 DEBUG FOP - File not found: file:/home/jbq/var/repos/cocoon/trunk/core/cocoon-webapp/target/cocoon-webapp/samples/fop/misc/ context://resources/images/cocoon.gif btpool0-2 ERROR fo.FONode - Image not available: /home/jbq/var/repos/cocoon/trunk/core/cocoon-webapp/target/cocoon-webapp/samples/fop/misc/ context://resources/images/cocoon.gif
        Hide
        Jean-Baptiste Quenot added a comment -
        Seems like the href is wrong *before* entering FOPNGSerializer.resolve():

        btpool0-2 DEBUG serializer.fo2pdf - resolve(href = /home/jbq/var/repos/cocoon/trunk/core/cocoon-webapp/target/cocoon-webapp/samples/fop/misc/context://resources/images/cocoon.gif, base = null); resolver = org.apache.cocoon.components.source.CocoonSourceResolver@1637d45
        Show
        Jean-Baptiste Quenot added a comment - Seems like the href is wrong *before* entering FOPNGSerializer.resolve(): btpool0-2 DEBUG serializer.fo2pdf - resolve(href = /home/jbq/var/repos/cocoon/trunk/core/cocoon-webapp/target/cocoon-webapp/samples/fop/misc/ context://resources/images/cocoon.gif, base = null); resolver = org.apache.cocoon.components.source.CocoonSourceResolver@1637d45
        Hide
        Jean-Baptiste Quenot added a comment -
        Committed revision 452332, thanks!
        Show
        Jean-Baptiste Quenot added a comment - Committed revision 452332, thanks!

          People

          • Assignee:
            Jean-Baptiste Quenot
            Reporter:
            Lars Trieloff
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development