Cocoon
  1. Cocoon
  2. COCOON-1786

BrowserUpdateTransformer can get into invalid state - must override recycle()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.8, 2.1.9
    • Fix Version/s: None
    • Component/s: Blocks: Ajax
    • Labels:
      None
    • Urgency:
      Urgent
    • Other Info:
      Patch available

      Description

      If a form throws an exception during transformation (see https://issues.apache.org/jira/browse/COCOON-1785) then the BrowserUpdateTransformer gets into an invalid state, and futher request by any user or session that happens to use the invalid transformer receive the entire form document inside of the bu:document tag. The client side ajax javascript is then unable to process the resulting update.

      The attached patch (license granted to ASF) overrides recycle() and fixes this problem.

        Activity

        Hide
        Antonio Gallardo added a comment -
        Improved Second patch applied. Would you cross check the patch and close the issue?
        Show
        Antonio Gallardo added a comment - Improved Second patch applied. Would you cross check the patch and close the issue?
        Hide
        Eric Meyer added a comment -
        Upon reflection, this is more a task for the setup() method. Recycle should deal with releasing references. I've created a new patch that moves the initialization to setup(). I added nulling the reference to the Locator to the recycle() method.
        Show
        Eric Meyer added a comment - Upon reflection, this is more a task for the setup() method. Recycle should deal with releasing references. I've created a new patch that moves the initialization to setup(). I added nulling the reference to the Locator to the recycle() method.
        Hide
        Antonio Gallardo added a comment -
        Thanks for the patch!
        The patch was applied. Please cross check and close the bug.
        Show
        Antonio Gallardo added a comment - Thanks for the patch! The patch was applied. Please cross check and close the bug.

          People

          • Assignee:
            Antonio Gallardo
            Reporter:
            Eric Meyer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development