Cocoon
  1. Cocoon
  2. COCOON-1771

cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.8
    • Fix Version/s: None
    • Component/s: Blocks: Ajax
    • Labels:
      None
    • Urgency:
      Normal
    • Other Info:
      Patch available

      Description

      In cocoon.ajax.Fader

        this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));

      getBgColor will return '#fff'

      /** Converts a "#RRGGBB" color as an array of 3 ints */
      cocoon.ajax.Fader.colorToRgb = function(hex) {
          return [
              parseInt(hex.substr(1,2),16),
              parseInt(hex.substr(3,2),16),
              parseInt(hex.substr(5,2),16) ];
      }

      Assumes that hex starts with a '#' and has 6 additional hex characters.

      The corrected implementation is

      /** Converts a "#RRGGBB" color as an array of 3 ints */
      cocoon.ajax.Fader.colorToRgb = function(hex) {
      var r = 255; // defaults if no match
      var g = 255;
      var b = 255;
      var i=-1;
      var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
      if (colors) {
      r = parseInt(colors[++i]);
      g = parseInt(colors[++i]);
      b = parseInt(colors[++i]);
      } else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
      r = parseInt(colors[++i] + colors[i]);
      g = parseInt(colors[++i] + colors[i]);
      b = parseInt(colors[++i] + colors[i]);
      }
          return [r,g,b];
      }

      Patch attached.

      Regards,
      Eric Meyer, VP, Quoin, Inc.
      1. cocoon-ajax.js.patch
        1 kB
        Eric Meyer
      2. cocoon-ajax.js.patch
        2 kB
      3. cocoon-ajax.js.patch
        2 kB
        Eric Meyer
      4. ASF.LICENSE.NOT.GRANTED--cocoon-ajax.js.patch
        0.9 kB
        Eric Meyer

        Activity

          People

          • Assignee:
            Antonio Gallardo
            Reporter:
            Eric Meyer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development