[CMIS-714] Update Smoke Test: always fail with empty properties

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: OpenCMIS 0.10.0
• Fix Version/s: OpenCMIS 0.12.0
• Component/s: opencmis-tck
• Assignee: Florian Müller
• Reporter: Jaime Porras López
• Created: 29/Aug/13 09:26
• Updated: 13/Aug/14 22:51
• Resolved: 29/Aug/13 11:48

Description

Update a docuemnt with an empty set of properties is tried as part of the Update Smoke Test. This is always failing because the OpenCMIS client is checking that the set ois not empty. So the exception is always thrown in the OpenCMIS client, not in the server.

Update Smoke Test code

org.apache.chemistry.opencmis.tck.tests.crud.UpdateSmokeTest.updateDocument(Session, Folder)
	...
        // update nothing
        try {
            properties = new HashMap<String, Object>();
            doc2.updateProperties(properties, false);
        } catch (Exception e) {
            addResult(createResult(WARNING,
                    "updateProperties without property changes returned an error: " + e.getMessage(), e, false));
        }
	...

OpenCMIS client code

		
org.apache.chemistry.opencmis.client.runtime.AbstractCmisObject.updateProperties(Map<String, ?>, boolean)
	...
        if (properties == null || properties.isEmpty()) {
            throw new IllegalArgumentException("Properties must not be empty!");
        }
	...