[CMIS-645] ACL is not applied when a document\folder is being created

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: DotCMIS 0.6
• Component/s: dotcmis
• Assignee: Florian Müller
• Reporter: Denis Andreev
• Created: 16/Apr/13 12:47
• Updated: 19/Apr/13 07:56
• Resolved: 19/Apr/13 07:56

Description

There is an issue with ACL applying when a document or folder is being created.
The code below does not work:
IDocument cmisDoc = folder.CreateDocument(properties, contentStream, null, null, cmisAces, null, new OperationContext()

{ IncludeAcls = true }

);

cmisDoc.Acl does not contain provided ACEs.

But after that :
cmisDoc.ApplyAcl(cmisAces, null, AclPropagation.RepositoryDetermined);

It does.

I looked into the code and found out that the method DotCMIS.Binding.AtomPub.ObjectService.HandleAclModifications() seems to be working in a wrong way.
The condition in the code below “if (originalAces != null)” is always false. If I comment it then it works.

private void HandleAclModifications(String repositoryId, AtomEntry entry, IAcl addAces, IAcl removeAces)
{
if (!IsAclMergeRequired(addAces, removeAces))

{ return; }

IAcl originalAces = null;

// walk through the entry and find the current ACL
foreach (AtomElement element in entry.GetElements())
{
if (element.Object is cmisObjectType)

{ // extract current ACL cmisObjectType cmisObject = (cmisObjectType)element.Object; originalAces = Converter.Convert(cmisObject.acl, cmisObject.exactACLSpecified ? (bool?)cmisObject.exactACL : null); break; }

}

if (originalAces != null)
{
// merge and update ACL
IAcl newACL = MergeAcls(originalAces, addAces, removeAces);
if (newACL != null)

{ UpdateAcl(repositoryId, entry.Id, newACL, null); }

}
}