[CMIS-640] Error in SQL grammer: OpenCMIS is enforcing a whitespace that is not required in the CMIS spec

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: OpenCMIS 0.8.0
• Component/s: opencmis-server
• Assignee: Jens Hübel
• Reporter: Stefan Kopf
• Created: 18/Mar/13 13:41
• Updated: 20/Jun/13 14:14

Description

The OpenCMIS sql parser is enforsing at least one whitespace character between the "TIMESTAMP" token and the timestamp string. The input

    TIMESTAMP '2013-....'

is accepted while the input

    TIMESTAMP'2013-...'

is rejected.
This is not correct. This whitespace char is not required in CMIS 1.0 spec. See line 2419 in chapter 2.1.10.2.1 of the cmis 1.0 spec.

This problem is caused by this definition in CmisBaseLexer.g:

WS : ( ' ' | '\t' | '\r'? '\n' )+ { $channel=HIDDEN; };

TIME_LIT : TIMESTAMP WS STRING_LIT;

The "+" is "one or more" elements. We should use "*" as "zero or more".
This should work:

TIME_LIT_WS : ( ' ' | '\t' | '\r'? '\n' )* { $channel=HIDDEN; };

TIME_LIT : TIMESTAMP TIME_LIT_WS STRING_LIT;

But I think we should also be able to just write:

TIME_LIT : TIMESTAMP STRING_LIT;