Chemistry
  1. Chemistry
  2. CMIS-521

Empty non-required ID properties on documents are mistakenly flagged as a test failures

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Not a Problem
    • Affects Version/s: OpenCMIS 0.7.0
    • Fix Version/s: OpenCMIS 0.7.0
    • Component/s: opencmis-tck
    • Labels:
    • Environment:

      n/a

      Description

      I just noticed that we have failures when we run against our public P8 CMIS server

      (Ask Florian for url/creds/etc for our test server - he has them)

      Here is what is happening. The class CMISScalars is a test class with a bunch of test properties to exercise property persistence.
      CMISObject is a not-required prop of type ID.

      When it is not set (as it is not usually set in our tests) is comes across in the XML responses like this:

      <cmis:propertyId queryName="CMISObject" displayName="CMISObject" localName="CMISObject" propertyDefinitionId="CMISObject"/>

      That is - empty, which is valid.

      But the TCK test fails in several places when it encounters objects with this unset property with this message:

      FAILURE: PWC check: idd_FA946B30-018C-42C2-AE69-E4EDACCB894F (AbstractCmisTest.java:125)
      FAILURE: Property CMISObject (AbstractSessionTest.java:2847)
      FAILURE: Property is not included in response! (AbstractSessionTest.java:2845)
      INFO: Object is null!

      AbstractSessionTest.checkProperty is getting called for this prop and it is dutifully returning a failure since its null. (at least that is what it looks like)

        Activity

        jay brown made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Not A Problem [ 8 ]
        Hide
        jay brown added a comment -

        Problem was on vendor side. Not with TCK.

        Show
        jay brown added a comment - Problem was on vendor side. Not with TCK.
        Hide
        jay brown added a comment -

        Thanks Florian for looking into this so quickly! We have verified your findings and will resolve on our end.

        Show
        jay brown added a comment - Thanks Florian for looking into this so quickly! We have verified your findings and will resolve on our end.
        Hide
        Florian Müller added a comment -

        I have done some debugging against the P8 CMIS server.

        The reported TCK failures only occur if the checked objects have been returned from getCheckedOutDocs().
        The property "CMISObject" is actually not returned in that case. It is missing in the AtomPub response.
        Therefore, the reported failure seems to be correct.

        Show
        Florian Müller added a comment - I have done some debugging against the P8 CMIS server. The reported TCK failures only occur if the checked objects have been returned from getCheckedOutDocs(). The property "CMISObject" is actually not returned in that case. It is missing in the AtomPub response. Therefore, the reported failure seems to be correct.
        jay brown created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            jay brown
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development